Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.0 #1253

Merged
merged 2 commits into from
Aug 19, 2024
Merged

v8.0.0 #1253

merged 2 commits into from
Aug 19, 2024

Conversation

mymindstorm
Copy link
Member

No description provided.

@mymindstorm mymindstorm requested a review from Sneezry August 14, 2024 04:39
@Sneezry
Copy link
Member

Sneezry commented Aug 15, 2024

Let's remove short_name

mymindstorm

This comment was marked as duplicate.

@mymindstorm
Copy link
Member Author

@Sneezry do you want it removed for Chrome and Firefox too?

@Sneezry
Copy link
Member

Sneezry commented Aug 19, 2024

It's okay to keep for Chrome and Firefox. There is still some issues for i18n. Some translations are empty strings. I have fixes that in Crowdin yesterday, but haven't update dev branch.

@mymindstorm
Copy link
Member Author

@Sneezry good catch! I'll go ahead and push the changes.

@mymindstorm
Copy link
Member Author

mymindstorm commented Aug 19, 2024

PR: #1258

@mymindstorm mymindstorm merged commit 68e5736 into dev Aug 19, 2024
10 checks passed
@mymindstorm mymindstorm deleted the mymindstorm/8.0.0 branch August 19, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants