Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't insert content script on chrome:// pages when autofill is enabled #1214

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

mymindstorm
Copy link
Member

@mymindstorm mymindstorm commented Jun 26, 2024

Fixes #1203

@mymindstorm mymindstorm changed the title Fix #1203 Don't insert content script on chrome:// pages when autofill is enabled Jun 26, 2024
@mymindstorm mymindstorm requested a review from Sneezry June 26, 2024 00:42
@mymindstorm
Copy link
Member Author

Blocked by #1216

@Sneezry
Copy link
Member

Sneezry commented Jun 26, 2024

Should edge:// be considered as well?

@mymindstorm
Copy link
Member Author

mymindstorm commented Jun 26, 2024 via email

@Sneezry
Copy link
Member

Sneezry commented Jun 26, 2024

Rather than blacklist, perhaps we should just whitelist https:// and http://? Not sure about file://

-------- Original message -------- From: Zhe Li @.> Date: 6/25/24 11:22 PM (GMT-06:00) To: Authenticator-Extension/Authenticator @.> Cc: Brendan Early @.>, Author @.> Subject: Re: [Authenticator-Extension/Authenticator] Don't insert content script on chrome:// pages when autofill is enabled (PR #1214) Should edge:// be considered as well? — Reply to this email directly, view it on GitHub<#1214 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGUAT3S35KTLGFUPJZWXXVLZJI6WLAVCNFSM6AAAAABJ422P4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGU3DANJQGU. You are receiving this because you authored the thread.Message ID: @.***>

I completely agree with using allowlist instead of disallowlist. Additionally, we should ensure to include the file:// protocol.

@mymindstorm mymindstorm force-pushed the fix-entrycomponent-issue branch from b7cb5d7 to cc5d11f Compare June 29, 2024 19:04
@Sneezry Sneezry merged commit 320a999 into dev Jul 4, 2024
10 checks passed
@Sneezry Sneezry deleted the fix-entrycomponent-issue branch July 4, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot copy code by clicking on it
2 participants