-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't insert content script on chrome:// pages when autofill is enabled #1214
Conversation
Blocked by #1216 |
Should |
Rather than blacklist, perhaps we should just whitelist https:// and http://? Not sure about file://
…-------- Original message --------
From: Zhe Li ***@***.***>
Date: 6/25/24 11:22 PM (GMT-06:00)
To: Authenticator-Extension/Authenticator ***@***.***>
Cc: Brendan Early ***@***.***>, Author ***@***.***>
Subject: Re: [Authenticator-Extension/Authenticator] Don't insert content script on chrome:// pages when autofill is enabled (PR #1214)
Should edge:// be considered as well?
—
Reply to this email directly, view it on GitHub<#1214 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGUAT3S35KTLGFUPJZWXXVLZJI6WLAVCNFSM6AAAAABJ422P4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGU3DANJQGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I completely agree with using allowlist instead of disallowlist. Additionally, we should ensure to include the |
b7cb5d7
to
cc5d11f
Compare
Fixes #1203