do not set timestamp for publications #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead let PX4 set the local timestamp when receiving the data. In most cases the timestamp is only relevant for logging, or checked that it is not too old. This is to avoid relying on timesync, as we experienced a number of issues: - we had cases where on real setups, the time was off by more than 500ms, leading to rejected goto_setpoint samples. - when using AirSim SITL, there's generally a time mismatch. This was not closer investigated yet. - there's often warnings from timesync
GuillaumeLaine
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead let PX4 set the local timestamp when receiving the data. In most cases the timestamp is only relevant for logging, or checked that it is not too old.
This is to avoid relying on timesync, as we experienced a number of issues: