Added static typing to pydicer modules
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalmouiee
changed the title
pydicer modulespydicer modules
|
Thanks a lot @dalmouiee, this is great. Yeah given that all the tests are passing I don't see any issues here. I don't believe that static types are actually enforced when running Python code. But they will flag when unexpected types are being used by linters, so this will be super useful for anyone who uses PyDicer in their projects. |
pchlap
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pchlap,
Just thought I'd go ahead and add static typing to all of Pydicer and get back into contributing to the repo :)
Pytest was happy so I assume that the type additions are okay for now, but if anything pops up during real world usage, I'll be happy to fix things in the codebase. Not sure if additional tests will be needed for this static typing, may well be but let me know what you think...
I'll have a look around the issues we've got and get back into the swing of things. If you're happy with the types being added, happy to merge this through. Thanks!