[PHB24] Ranger & Paladin Classes + Subclasses #277
Conversation
This reverts commit dacbcb7.
…nto Telok-phb2024-1
|
Resolves #258 |
added missing flavor text, feature replacements and other small fixes
|
Seeing how I'll be updating my PR with some changes, should we update the "ASI" grants to be pointing towards feats instead (since ASIs are a type of feat now)?
should become
|
|
targeting feats would be |
These are the IDs for the class feature that grants feats. We'd have a I'm mostly just trying to nail down "ID naming conventions" for my PR edit later this weekend. |
|
but why? If all they do is grant Feats, why not just grant Feats right away? |
|
We need the "Class Feature" element so it shows up in the feature list of the class, just like Epic Boons. |
|
ah, yeah, then it should still be |
|
tbh then they should be selections, not grants.. remember that the feature let you choose between ASI or another Feat for which you qualify.. same thing with Epic Boons.. |
|
Right. We still need the "class feature" element so they show up in the list of class features. We then do a select in the rules of that class feature element to allow the user to pick their feat. I mostly was asking to change the ID of the "class feature" element to |
|
full name would probably be more appropriate, but i won't argue with an abbreviation either |
|
Well, what's the standard naming convention we want to go with, moving forward? |
Tel0k
force-pushed
the
Telok-phb2024-1
branch
from
539965a to
65cd377
Compare
Tel0k
changed the title
|
Resolves #257 |
| <div class="reference"> | ||
| <div element="ID_WOTC_PHB24_FEAT_BLESSED_WARRIOR" /> | ||
| </div> |
There was a problem hiding this comment.
Unfortunately, this <div> reference does not show up in the class description.
There was a problem hiding this comment.
this and the other divs are working properly though, as they show up fine in compendium entries
| <p>You can channel divine energy directly from the Outer Planes, using it to fuel magical effects. You start with one such effect: Divine Sense, which is described below. Other Paladin features give additional Channel Divinity effect options. Each time you use this class’s Channel Divinity, you choose which effect from this class to create.</p> | ||
| <p class="indent">You can use this class’s Channel Divinity twice. You regain one of its expended uses when you finish a Short Rest, and you regain all expended uses when you finish a Long Rest. You gain an additional use when you reach Paladin level 11.</p> | ||
| <p class="indent">If a Channel Divinity effect requires a saving throw, the DC equals the spell save DC from this class’s Spellcasting feature.</p> | ||
| <div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_CHANNEL_DIVINITY_DIVINE_SENSE" /> |
There was a problem hiding this comment.
Same as before. <div> elements do not show up in class descriptions.
Co-authored-by: tregolani <[email protected]>
| <grant type="Spell" id="ID_PHB_SPELL_COMMUNE" spellcasting="Paladin" level="17" prepared="true" /> | ||
| <grant type="Spell" id="ID_PHB_SPELL_FLAME_STRIKE" spellcasting="Paladin" level="17" prepared="true" /> --> |
There was a problem hiding this comment.
No, I meant the 5th level spells granted at lvl 17 don't match the table. Grants are giving Commune and Flame Strike, but should be Legend Lore and Yolande's Regal Presence
Co-authored-by: tregolani <[email protected]>
No description provided.