Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHB24] Items, proficiencies, properties, languages and alignments #275

Open
wants to merge 5 commits into
base: phb2024
Choose a base branch
from

Conversation

Tel0k
Copy link

@Tel0k Tel0k commented Sep 16, 2024

No description provided.

@kgirtxd kgirtxd linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few missing "2024" notations in proficiencies-all.xml.

Also, should we keep vehicle proficiencies? They seem to have been removed from the PHB24.

core/players-handbook-2024/misc/proficiencies-all.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/misc/proficiencies-all.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/misc/proficiencies-all.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/misc/proficiencies-all.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/misc/proficiencies-all.xml Outdated Show resolved Hide resolved
Comment on lines +777 to +793
<element name="Tool Proficiency (Vehicles (land))" type="Proficiency" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_VEHICLES_LAND">
<supports>Tool, Vehicles</supports>
<requirements />
<description>
<p></p>
</description>
<rules />
</element>
<element name="Tool Proficiency (Vehicles (water))" type="Proficiency" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_VEHICLES_WATER">
<supports>Tool, Vehicles</supports>
<requirements />
<description>
<p>You gain proficiency with Vehicles (water).</p>
</description>
<rules />
</element>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed these aren't actually in the PHB24 book anywhere. It seems they removed vehicle proficiencies with the version update?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages 229 and 230 of PHB24, those have actually been added to the new PHB while in the previous edition they were part of DMG

Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some typos found in my latest testing sessions.

core/players-handbook-2024/items/items-gear.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-gear.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-gear.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-gear.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-gear.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-tools.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-tools.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-tools.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/items/items-tools.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/misc/proficiencies-all.xml Outdated Show resolved Hide resolved
</element>

<element name="Persuasion" type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_PERSUASION" source="Player’s Handbook 2024">
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin</supports>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin</supports>
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin,ID_WOTC_PHB24_CLASS_FIGHTER,Fighter</supports>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items, proficiencies, properties, languages and alignments
2 participants