-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHB24] Items, proficiencies, properties, languages and alignments #275
base: phb2024
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few missing "2024" notations in proficiencies-all.xml.
Also, should we keep vehicle proficiencies? They seem to have been removed from the PHB24.
<element name="Tool Proficiency (Vehicles (land))" type="Proficiency" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_VEHICLES_LAND"> | ||
<supports>Tool, Vehicles</supports> | ||
<requirements /> | ||
<description> | ||
<p></p> | ||
</description> | ||
<rules /> | ||
</element> | ||
<element name="Tool Proficiency (Vehicles (water))" type="Proficiency" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_VEHICLES_WATER"> | ||
<supports>Tool, Vehicles</supports> | ||
<requirements /> | ||
<description> | ||
<p>You gain proficiency with Vehicles (water).</p> | ||
</description> | ||
<rules /> | ||
</element> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed these aren't actually in the PHB24 book anywhere. It seems they removed vehicle proficiencies with the version update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pages 229 and 230 of PHB24, those have actually been added to the new PHB while in the previous edition they were part of DMG
Co-authored-by: tregolani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some typos found in my latest testing sessions.
Co-authored-by: tregolani <[email protected]>
</element> | ||
|
||
<element name="Persuasion" type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_PERSUASION" source="Player’s Handbook 2024"> | ||
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin</supports> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin</supports> | |
<supports>Skill,Charisma,ID_PROFICIENCY_SKILL,ID_WOTC_PHB24_CLASS_ROGUE,Rogue,ID_WOTC_PHB24_CLASS_SORCERER,Sorcerer,ID_WOTC_PHB24_CLASS_CLERIC,Cleric,ID_WOTC_PHB24_CLASS_BARD,Bard,ID_WOTC_PHB24_CLASS_PALADIN,Paladin,ID_WOTC_PHB24_CLASS_FIGHTER,Fighter</supports> |
Co-authored-by: tregolani <[email protected]>
No description provided.