WIP: Use vite instead of webpack #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove onerror tags where they are obsolete. imgError also fails to load in production, so it looks like dead code. Remove imgError.ts as well.
It appears that if 2factor is started, the client sends the HI with the current fingerprint (as hdid), but in the 2fa block it also sends the cookie hdid with no header. It seems unlikely that the server can parse this packet correctly, so this looks like a mistake. Remove this sendServer line and only do the 2factor flow when it's enabled, do not send handshake to the server otherwise.
This is broken in production and hence is not used
| <meta http-equiv="X-WebKit-CSP" | ||
| content="default-src 'self' 'unsafe-inline' 'unsafe-eval' *.aceattorneyonline.com data:; frame-src http://servers.aceattorneyonline.com https://servers.aceattorneyonline.com; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; font-src 'self' https://fonts.gstatic.com; connect-src 'self' http://servers.aceattorneyonline.com https://servers.aceattorneyonline.com ws:;"> | ||
| content="default-src 'self' 'unsafe-inline' 'unsafe-eval' *.aceattorneyonline.com data:; | ||
| script-src 'self' 'unsafe-inline' https://static.cloudflareinsights.com; |
There was a problem hiding this comment.
this breaks loading the serverlist and also i don't want the analytics to track all users
There was a problem hiding this comment.
can't have shit in detroit
| loadResources: () => void | ||
| isLowMemory: () => void | ||
| // loadResources: () => void | ||
| // isLowMemory: () => void |
There was a problem hiding this comment.
this has been done for a reason, it actually helps
| */ | ||
| export function imgError(image: HTMLImageElement) { | ||
| image.onerror = null; | ||
| image.src = ""; // unload so the old sprite doesn't persist |
There was a problem hiding this comment.
this will cause little error images to be all over the viewport
| @@ -10,7 +10,7 @@ import { appendICLog } from '../../client/appendICLog' | |||
| export const handleMC = (args: string[]) => { | |||
| const track = prepChat(args[1]); | |||
| let charID = Number(args[2]); | |||
| const showname = args[3] || ""; | |||
| // const showname = args[3] || ""; | |||
There was a problem hiding this comment.
?????????
why ignore shownames??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using webpack's dev server exhibits some strange and inconsistent behavior, such as failing to display the dev URL, the build process hanging (shows as disconnected from process in VSC). This behavior seems to appear on both VSC and WebStorm. Vite also has faster rebuild times and should all in all provide a better development environment. This PR is an experiment in replacing webpack with vite and should not be merged before it is confirmed that all use cases work correctly. That is:
npm installworks out of the box)npm run devstarts a development webserver which can be accessed at localhost AND debugger+breakpoints work correctly)This PR makes the following changes:
Work in progress, do not merge