Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework query param parsing and set window title to server name #196

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Rework query param parsing and set window title to server name #196

merged 5 commits into from
Nov 13, 2023

Conversation

OmniTroid
Copy link
Contributor

  • Replace custom query param parsing with URLSearchParams, and move all defaults into that file
  • add serverName to query params
  • set window title to server name on joining
  • add error checking on missing mandatory query param (server ip)
  • formatting

In case of multiclienting in multiple tabs, this should be useful to keep track of which tab is connected to which server. If it hasn't been changed, the desktop client also does this. In the future, it might even make sense to add the area name to the window title as well.

@stonedDiscord stonedDiscord merged commit 074114f into AttorneyOnline:master Nov 13, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants