WIP: Add server nickname #310
Closed
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to conflict with #300 |
Salanto
reviewed
Jul 13, 2022
| @@ -301,6 +301,11 @@ QString ConfigManager::serverName() | |||
| return m_settings->value("Options/server_name", "An Unnamed Server").toString(); | |||
| } | |||
|
|
|||
| QString ConfigManager::serverNick() | |||
| { | |||
| return m_settings->value("Options/server_nick", "").toString(); | |||
There was a problem hiding this comment.
Suggested change
| return m_settings->value("Options/server_nick", "").toString(); | |
| return m_settings->value("Options/server_nick", "NickName").toString(); |
If the key is missing we don't want an empty value, as that would look very silly when viewed in client.
|
isn't this the same as serverName or am i missing something here? |
|
closed as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #288
Not sure what to put as the default nickname in the sample config.