-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/issue 314 - Ability to add worklog during issue transition #343
base: develop
Are you sure you want to change the base?
Conversation
@@ -41,6 +41,9 @@ function Invoke-JiraIssueTransition { | |||
[String] | |||
$Comment, | |||
|
|||
[String] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason why not to use [TimeSpan]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's much common practice to use in JQL things like 10m, 8h, 3w and people get used to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also TimeSpan is more .NET solution rather than Powershell. It should be simple to use the Module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well...
we already have the [TimeSpan]
behavior in the module (for the worklog to be precise)
JiraPS/JiraPS/Public/Add-JiraIssueWorklog.ps1
Lines 36 to 38 in 947628c
[Parameter( Mandatory, ValueFromPipeline, ValueFromPipelineByPropertyName )] | |
[TimeSpan] | |
$TimeSpent, |
We can discuss the behavior of SpentTime as [string] vs [TimeSpan] here, all the pros and cons |
hey @alexsuslin . We can change the behavior, but then I would plea to change it in the other places as well. So I would suggest, to implement it as |
@alexsuslin : can you please update the pull request? |
Description
Invoke-JiraIssueTransition now have additional parameter -TimeSpent where user can add worklog time he is working on this issue
Motivation and Context
I would like to resolve the issue and specify worklog time
Types of changes
Checklist