Dev #236
Merged
Dev #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a solution yet, but sets up architecture for running tests using secret information
- add `check_field_identities()` to perform a check on retuned field names; but not correct them (returns warning if triggered) - remove `enforce_field_names_and_types()` - read_csv() now automatically converts assertions to logical, meaning `fix_assertion_cols()` no longer needed
Separate warnings for additions vs subtractions, noting it is possible for both to occur simultaneously
- add species list and image licence APIs for SBDI - enable image services for SBDI and BAO (neither tests successfully yet) - remove canadensys.net APIs (unused) - upgrade `collect_licences()` and `collect_media_metadata()` to not fail for empty results
Still need a function to download maps in a usable format
- write methods for `data/distributions` and `metadata/distributions` - ensure `data` approach returns valid spatial objects - support filtering by ID, taxonomic arguments with `identify()` - build unexported (for now) `build_query_set()` for debugging - tests for the above
If not, a message is posted that states they are calling the ALA.
- ensure working APIs for atlases using pipelines infrastructure - use less intrusive column renaming - remove APIs for atlases where we have been unable to test downloads (Portugal and Estonia)
Alters behaviour added in commit 156cc33. Note that behaviour of tracking whether a user has manually specified which node to use is retained; may be useful down the track.
…s_counts()` Basic problem was using `label` field returned by JSON instead of the actual field value. Test added for the same.
Information was being incorrectly added to the `data_request`, and was missing a test for this use case.
* Add `galah_radius()` function * Allow "radius" as an argument to `galah_geolocate()` * Allow `galah_radius()` arguments to pass to correct url arguments in `build_query()`
Fixes bugs added in commit 7c61a7c
Help file already updated
Had to amend behavior in `quosure_handling.R` to cover unusual cases when assertions are used for filtering (i.e. fewer brackets). Assertions queries must be placed before other queries to work. Tests updated in `galah_filter()`, but some still fail and require further investigation. Clean up `browser()` calls and run `document()`.
- Expert distribution APIs not fully tested yet; code retained - occurrences/facets/downloads removed from UK and Guatemala (non-functional) - Require further checks before decision on Austria biocache and Sweden images - GBIF download by DOI should be functional - add - atlases_plot.png updated to current status
- query builder didn't recognise geolocate as a filter, so errored unnecessarily - location argument failing when specified in a way not expected by query builder
- reconfigure quick start guide to use dplyr syntax - fix minor bugs - consistency in author names
The only 'real' bug here is not generating an API properly - fixed in `collapse()` by making sure arguments are passed on correctly
* Adds `max=-1` argument to queries sent using `search_all(lists, "list-id") |> show_values()`
Uses `geometry` arg for WKT, or `geoDistance` for radius-based queries
Also reorder functions in help for `galah_geolocate()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.