UI - use authorization check to determine launch provider access #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtjomsPorss
commented
Nov 21, 2024
Comment on lines
1097
to
1107
| new Promise((resolve, reject) => { | ||
| req.clients.zms.getPolicy(param, (err, data) => { | ||
| req.clients.zms.getAccessExt(param, (err, data) => { | ||
| res.provider[provider.id] = 'not'; | ||
| if (err) { | ||
| if (err.status !== 404) { | ||
| reject(err); | ||
| } | ||
| } | ||
| if ( | ||
| data && | ||
| data.assertions && | ||
| data.assertions.some( | ||
| (a) => | ||
| a.resource && | ||
| a.resource === service && | ||
| a.action && | ||
| a.action === 'launch' | ||
| ) | ||
| ) { | ||
| if (data && data.granted) { | ||
| res.provider[provider.id] = 'allow'; | ||
| } |
There was a problem hiding this comment.
data is returned in form of { granted:true|false }
ArtjomsPorss
commented
Nov 21, 2024
Comment on lines
1127
to
1133
| }, | ||
| }); | ||
|
|
||
| Fetchr.registerService({ | ||
| name: 'provider', | ||
| create(req, resource, params, body, config, callback) { | ||
| req.clients.zms.putDomainTemplate( |
There was a problem hiding this comment.
'provider' create is now a separately registered fetchr API - previously both create and read were registered together. read is now registered as 'access' endpoint (above)
ArtjomsPorss
force-pushed
the
launch-provider-check
branch
2 times, most recently
from
25e95f2 to
d1eba4a
Compare
ArtjomsPorss
force-pushed
the
launch-provider-check
branch
2 times, most recently
from
a8b2d83 to
139fa6f
Compare
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
force-pushed
the
launch-provider-check
branch
from
139fa6f to
31a7b87
Compare
MartinTrojans
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI - use access api to determine if the service provider is enabled or not to support access enabled via Terraform.
Contribution Checklist: