Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare update + change dockerfile #27

Merged
merged 32 commits into from
Nov 9, 2023
Merged

Conversation

Astro-Otter-Space
Copy link
Owner

@Astro-Otter-Space Astro-Otter-Space commented Oct 16, 2023

Upgrade code to PHP 8.2, adding RectorPHP rules for code quality

@Astro-Otter-Space Astro-Otter-Space added enhancement New feature or request php labels Oct 16, 2023
@Astro-Otter-Space Astro-Otter-Space self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #27 (5b3f1dc) into master (f399a78) will increase coverage by 8.02%.
The diff coverage is 89.47%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
+ Coverage     84.10%   92.13%   +8.02%     
- Complexity      127      130       +3     
============================================
  Files            18       18              
  Lines           302      305       +3     
============================================
+ Hits            254      281      +27     
+ Misses           48       24      -24     
Files Coverage Δ
src/GuzzleSingleton.php 100.00% <ø> (ø)
src/Response/DTO/AstrobinError.php 100.00% <100.00%> (ø)
src/Response/DTO/Collection/ListCollection.php 100.00% <ø> (+100.00%) ⬆️
src/Response/DTO/Collection/ListImages.php 100.00% <ø> (ø)
src/Response/DTO/Collection/ListToday.php 100.00% <ø> (ø)
src/Response/DTO/Item/Collection.php 100.00% <100.00%> (+100.00%) ⬆️
src/Response/DTO/Item/Image.php 100.00% <100.00%> (+100.00%) ⬆️
src/Response/EntityFactory.php 100.00% <ø> (ø)
src/Services/GetCollection.php 100.00% <ø> (ø)
src/Services/GetImage.php 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f399a78...5b3f1dc. Read the comment docs.

@Astro-Otter-Space Astro-Otter-Space merged commit 66ab9d0 into master Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request php
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant