Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate client/runtime release #1352

Merged
merged 18 commits into from
Sep 11, 2024
Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Sep 5, 2024

Pull Request Summary

Closes #1347

  • breaks release into runtime & client
  • client release is triggered same as before, by pushing a vX.Y.Z tag
  • runtime release is triggered by pushing runtime-ABCD (arbitrary amount of numbers)
    • the first time it's pushed, commit delta will be compared against the latest vX.Y.Z release

@Dinonard Dinonard added ci This PR/Issue is related to the topic "CI" other PR/issue is related to third-party, scripts or other things which don't have definite label. labels Sep 5, 2024
@Dinonard Dinonard marked this pull request as ready for review September 6, 2024 14:23
@Dinonard
Copy link
Member Author

Dinonard commented Sep 6, 2024

Tested on repo fork, draft generation works fine.

ipapandinas
ipapandinas previously approved these changes Sep 9, 2024
Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard
Copy link
Member Author

Dinonard commented Sep 9, 2024

@ermalkaleci I had to manually port some of your change(s) so please check if all is fine.

After this is merged, I'll do some test releases just to make sure everything works.

@ermalkaleci
Copy link
Contributor

@Dinonard we can test before merge using workflow_dispatch

@ermalkaleci
Copy link
Contributor

try upgrading upload/download artifacts to v4 after we make sure workflow is correct

@Dinonard
Copy link
Member Author

@ermalkaleci sure, I can repeat the tests here but this has all been tested already in my fork.

For v4 upload/download, I'd prefer to do it in another PR.
I saw that dependabot opened a PR for this, but if I remember correctly, you did uplift these versions once and things fell apart a bit so we had to revert.

@ermalkaleci
Copy link
Contributor

@Dinonard we bumped it once but our setup had issues with duplicated and then we revert back to v3

@Dinonard
Copy link
Member Author

@ermalkaleci craeted an issue for it, will handle it outside of this PR.

Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/xc-asset-config/src 50% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/assets-erc20/src 78% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/collective-proxy/src 86% 0%
pallets/ethereum-checked/src 74% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/xcm/src 71% 0%
pallets/vesting-mbm/src 89% 0%
precompiles/dapp-staking/src 90% 0%
primitives/src 57% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/price-aggregator/src 82% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/sr25519/src 64% 0%
pallets/static-price-provider/src 85% 0%
precompiles/unified-accounts/src 100% 0%
primitives/src/xcm 65% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/unified-accounts/src 86% 0%
precompiles/dapp-staking/src/test 0% 0%
pallets/inflation/src 89% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking/src 83% 0%
chain-extensions/unified-accounts/src 0% 0%
Summary 79% (3726 / 4730) 0% (0 / 0)

Minimum allowed line rate is 50%

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ermal Kaleci <[email protected]>
@Dinonard
Copy link
Member Author

@ermalkaleci @ipapandinas all comments are resolved & it's been tested. Please re-approve.

@Dinonard Dinonard merged commit 817717c into master Sep 11, 2024
7 of 8 checks passed
@Dinonard Dinonard deleted the ci/split-client-runtime-release branch September 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI" other PR/issue is related to third-party, scripts or other things which don't have definite label.
Projects
None yet
3 participants