-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate client/runtime release #1352
Conversation
Tested on repo fork, draft generation works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ermalkaleci I had to manually port some of your change(s) so please check if all is fine. After this is merged, I'll do some test releases just to make sure everything works. |
@Dinonard we can test before merge using workflow_dispatch |
try upgrading upload/download artifacts to v4 after we make sure workflow is correct |
Co-authored-by: Ermal Kaleci <[email protected]>
@ermalkaleci sure, I can repeat the tests here but this has all been tested already in my fork. For |
@Dinonard we bumped it once but our setup had issues with duplicated and then we revert back to v3 |
@ermalkaleci craeted an issue for it, will handle it outside of this PR. |
Minimum allowed line rate is |
Co-authored-by: Ermal Kaleci <[email protected]>
@ermalkaleci @ipapandinas all comments are resolved & it's been tested. Please re-approve. |
Pull Request Summary
Closes #1347
vX.Y.Z
tagruntime-ABCD
(arbitrary amount of numbers)vX.Y.Z
release