Powershell Changes for Security Type #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamverma-ms
changed the title
singhabh27
reviewed
Apr 1, 2024
| if ($HasTargetSecurityType -and $TargetSecurityType -ne "Standard") { | ||
| $ProviderSpecificDetails.TargetVMSecurityProfileTargetVmsecurityType = $TargetSecurityType | ||
| $ProviderSpecificDetails.TargetVMSecurityProfileIsTargetVmtpmEnabled = $true | ||
| } elseif($HasTargetVMSecureBootEnabled) { |
| $ProviderSpecificDetails.TargetVMSecurityProfileIsTargetVmsecureBootEnabled = $TargetVMSecureBootEnabled | ||
| } | ||
|
|
||
| if ($HasTargetSecurityType -and $TargetSecurityType -ne "Standard") { |
There was a problem hiding this comment.
What if SecureBoot is not passed and SecurityType is TrustedLaunch?
Do we need to keep default value of SecureBoot as True or throw error asking user to provide SecureBoot input? Check with PM.
| $ProviderSpecificDetails.TargetVMSecurityProfileTargetVmsecurityType = $TargetSecurityType | ||
| $ProviderSpecificDetails.TargetVMSecurityProfileIsTargetVmtpmEnabled = $true | ||
| } elseif($HasTargetVMSecureBootEnabled) { | ||
| throw "SecureBoot when security type is trusted launch virtual machine." |
There was a problem hiding this comment.
Get the error message reviewed from PM.
| @@ -639,6 +668,7 @@ public static int hashForArtifact(String artifact) | |||
| } | |||
|
|
|||
| Import-Module Az.Resources | |||
| Import-Module Az.Compute | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.