Adds a comma inbetween the flags when writing to xml #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsherGlick
requested changes
Oct 31, 2023
Comment on lines
85
to
89
| for (size_t i = 0; i < flag_values.size(); ++i) { | ||
| output += flag_values[i]; | ||
| if (i < flag_values.size() - 1) { | ||
| output += ","; | ||
| } |
There was a problem hiding this comment.
use the stringhelper join function instead here. It does exactly what you want and (will soon have) an optimization to preallocate the full size of the output string instead of reallocating each iteration of the loop.
|
Also add a new testcase for this change to prove the code is doing what you expect. |
AsherGlick
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #190
The filter classes are currently outputting incorrect information. The filters should have an output with a comma between.
e.g. Mount="raptor,springer,beetle" but we are currently outputting Mount="raptorspringerbeetle"