Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StatRange Vision in Crafting #2368

Closed
wants to merge 2 commits into from

Conversation

cydyn
Copy link

@cydyn cydyn commented Aug 3, 2024

Fix: #2356
Fix logic for showing statrange and statgive in crafting
The photos show two cases: Statgive + Statrange and StatGive alone, in the second case only Statgive is set.
It does not show 0 to 0 when statrange is not set and only statgive is set.

Zrzut ekranu 2024-07-30 194456
Zrzut ekranu 2024-07-30 194516
Zrzut ekranu 2024-07-30 194715
Zrzut ekranu 2024-07-30 194753

@cydyn
Copy link
Author

cydyn commented Aug 3, 2024

I open new PR because old no update

@Arufonsu Arufonsu added the invalid Issue report doesn't comply with the proper format label Aug 8, 2024
@cydyn cydyn changed the title Fix StatRange Vision in Crafting Fix: StatRange Vision in Crafting Aug 9, 2024
@cydyn
Copy link
Author

cydyn commented Aug 9, 2024

@Arufonsu I corrected the PR title and updated it to the new version. is everything OK now?

@cydyn cydyn changed the title Fix: StatRange Vision in Crafting fix: StatRange Vision in Crafting Aug 9, 2024
@Arufonsu Arufonsu added bug fix Pull request that fixes a bug and removed invalid Issue report doesn't comply with the proper format labels Nov 27, 2024
@lodicolo
Copy link
Member

Closing in favor of #2438 which fixes the underlying issue as well as makes an additional correction

@lodicolo lodicolo closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Incorrect statgrowthrange calculation
3 participants