fix: Cache player party in Entity.Die to avoid Collection Modified Ex…

…ceptions (#1914)
AscensionGameDev · Sep 20, 2023 · 0363f11 · 0363f11
1 parent 63ba58a
commit 0363f11
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Intersect.Server/Entities/Entity.cs b/Intersect.Server/Entities/Entity.cs
@@ -2834,11 +2834,15 @@ public virtual void Die(bool dropItems = true, Entity killer = null)
                         var player = Player.FindOnline(entityEntry);
                         if (player != null)
                         {
+
+                            // Cache our value for further processing.
+                            var party = player.Party.ToArray();
+
                             // is this player in a party?
-                            if (player.Party.Count > 0 && Options.Instance.LootOpts.IndividualizedLootAutoIncludePartyMembers)
+                            if (party.Length > 0 && Options.Instance.LootOpts.IndividualizedLootAutoIncludePartyMembers)
                             {
                                 // They are, so check for all party members and drop if still eligible!
-                                foreach (var partyMember in player.Party)
+                                foreach (var partyMember in party)
                                 {
                                     if (!lootGenerated.Contains(partyMember))
                                     {