Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored app.js and created config file #39

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Refactored app.js and created config file #39

merged 4 commits into from
Oct 4, 2023

Conversation

Dharansh-Neema
Copy link
Contributor

  • I have refactored App.js API as of now
  • make views folder accessible from anywhere
  • added some comment to make the code more readable
  • created config folder.

@Dharansh-Neema Dharansh-Neema mentioned this pull request Oct 2, 2023
Closed
Artlfmj
Artlfmj requested changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@Artlfmj Artlfmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the readme file you created, a setup file will be added by #30

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 3, 2023
View reviewed changes
src/app.js Dismissed Show dismissed Hide dismissed
@Artlfmj
Copy link
Owner

Artlfmj commented Oct 3, 2023

Have you tested and ran your code?

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 3, 2023

@Dharansh-Neema is this fully tested and ready to be deployed?

@Dharansh-Neema
Copy link
Contributor Author

Yes Sir!!! @Artlfmj

@Artlfmj Artlfmj merged commit 04838bc into Artlfmj:main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artlfmj Artlfmj Artlfmj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dharansh-Neema @Artlfmj