-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: forward cargo-check arguments; refactor cargo-rap #65
Merged
hxuhack
merged 30 commits into
Artisan-Lab:main
from
os-checker:feat/cargo-check-arguments-forwarding
Oct 26, 2024
Merged
feat: forward cargo-check arguments; refactor cargo-rap #65
hxuhack
merged 30 commits into
Artisan-Lab:main
from
os-checker:feat/cargo-check-arguments-forwarding
Oct 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining an iterator is a overkill for get_arg_flag_value.
is_target_crate fn is outdated, because --target may not be passed by user; but we don't need it to work: rustc can handle without it.
e.g. cargo rap -F -M -- --target riscv64gc-unknown-none-elf
also rename rap_args => args_group1, cargo_args => args_group2, due to two phases in cargo-rap: in rustc phase, the field name is incorrect.
there is a typo in original code: --crate--type will be never matched, so it's needless to call it. In this commit, is_crate_type_lib is refactored with get_arg_flag_value.
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marjor changes:
cargo clean
any more: this imporves checking time, and is fine for most cases; sometimes cargo caches won't emit MIRs, then users should runcargo clean
, especially for the existing cached projects.cargo check
, which means-- cargo check options
as shown above to select what to checkInternal changes:
#[macro_use] pub mod utils;
to import log macros to all sub modules via#[macro_use] extern crate rap;
from the root module