Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace "RAP_FRONT" with "RAP"; use ISO 8601 timestamp in log #60

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat: replace "RAP_FRONT" with "RAP"; use ISO 8601 timestamp in log #60

merged 2 commits into from
Oct 16, 2024

Conversation

WIZeaz
Copy link
Contributor

@WIZeaz WIZeaz commented Oct 16, 2024 •
edited
Loading

This PR changes log.rs to:

  • replace "RAP_FRONT" with "RAP". Since RAP no longer has the concepts of "frontend" and "backend", there is no means to use "RAP_FRONT".
  • use ISO 8601 timestamp for all logging. This facilitates the debugging and profiling of RAP.

Below is an example of the new logging format:
图片

hxuhack
hxuhack requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@hxuhack hxuhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timestamp is a bit too long. Could you shorten it? Thanks

@hxuhack hxuhack merged commit a9e3c29 into Artisan-Lab:main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hxuhack hxuhack hxuhack requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WIZeaz @hxuhack