Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use alt functions to read and save the base SE class. #3

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Don't use alt functions to read and save the base SE class. #3

merged 2 commits into from
Oct 23, 2024

Conversation

LTLA
Copy link
Member

@LTLA LTLA commented Oct 23, 2024

@LTLA
Don't use alt functions to read and save objects.
23f513d 
This is simpler and avoids repeated calls to the override when traversing down
the SCE class hierarchy via save_object() and read_object().

This reverts commit 3960958.
@LTLA LTLA requested a review from jkanche October 23, 2024 00:25
@LTLA LTLA changed the title Don't use alt functions to read and save objects. Don't use alt functions to read and save the base SE class. Oct 23, 2024
@jkanche jkanche self-assigned this Oct 23, 2024
@jkanche jkanche merged commit a7ed25d into master Oct 23, 2024
5 checks passed
@jkanche jkanche deleted the no-alt-save branch October 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkanche jkanche jkanche approved these changes

Assignees

@jkanche jkanche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LTLA @jkanche