Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say Sounds, Fixes Gender Setting! #347

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Say Sounds, Fixes Gender Setting! #347

merged 1 commit into from
Oct 31, 2023

Conversation

RimiNosha
Copy link
Contributor

@RimiNosha RimiNosha commented Oct 26, 2023 •
edited
Loading

About The Pull Request

Swipes the sounds from virgo, VOREStation/VOREStation#13333

How this works:

  • There's a normal say sound you can configure
  • There's a normal emote sound you can configure
  • Yelling is louder (in volume)
  • Asking has it's own sound
  • Subtle(r)s have their own sound

Also, the TGUI is shitcode, I'm aware. I don't have the patience to rewrite part of prefs TGUI code yet again.

Extra note: I won't be accepting goon sounds for say voices.

How Does This Help Gameplay?

More evident when someone near you is talking!
Also you can set your gender now, woops.

How Does This Help Roleplay?

Lets folk who're bar/ERPing know that someone just emoted, I guess!

Proof of Testing

Screenshots/Videos
2023-10-26.04-47-15.mp4

Changelog

🆑
add: Say sounds, me sounds, and subtle sounds!
fix: You can set your gender again.
/:cl:

@github-actions github-actions bot added Feature How I broke the server in one easy step! Fix Cleans up someone else's code from 5 years ago. Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". UI Also known as "I like lagspikes, so I added TGUI to your TGUI". labels Oct 26, 2023
@RimiNosha RimiNosha merged commit 8781184 into Artea-Station:master Oct 31, 2023
22 checks passed
Artea-Station-Bot added a commit that referenced this pull request Oct 31, 2023
@Artea-Station-Bot
Automatic changelog for PR #347 [ci skip]
ba361ed
@RimiNosha RimiNosha deleted the talk_sounds branch November 18, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature How I broke the server in one easy step! Fix Cleans up someone else's code from 5 years ago. Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". UI Also known as "I like lagspikes, so I added TGUI to your TGUI".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RimiNosha