Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriMesh conversion #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peteihis
Copy link
Contributor

@peteihis peteihis commented Apr 3, 2024

This fixes #4 the way it exists in the current code.

I also did some code formatting at the "Not found" comments and noticed that there were some more unnecessary lines related to making the comment "Not found". Just reporting "Not found" to System.out without any indication to what was not found may have been useful to the developer but it is entirely useless to the user. Also it has no effect on anything, so those parts were removed. EDIT: And that it was written in French suggests, that it was never meant to be left in the final code.

I have no idea how the .PATCH file should have been used. Anyway these fixes go beyond that.

I'll try to keep in mind to open the smoothed mesh image wrinkling as an issue if it's own.

@Sailsman63
Copy link
Member

Hey, sorry for missing this. In an attempt to clear some things off my plate, I was trying to go through some of the older stuff before looking at newer notifications.

I was able to apply Maksim's patch file (They are used mostly on the command line, git apply with some knobs to tweak. That's actually the canonical "intended" way to use git - this whole central hub thing is an add-on.

I'll come back in a bit and probably pull in the reformat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants