Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add draft for storage #92
feat(storage): add draft for storage #92
Changes from all commits
be656dc
2e4d809
817bb6c
25bc420
c94be4d
f01fb02
06b146d
a85c0ca
f4b9237
8639c0f
6b3fc47
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 120 in crates/ark-core/src/lib.rs
GitHub Actions / clippy
unneeded `return` statement
Check warning on line 122 in crates/ark-core/src/lib.rs
GitHub Actions / clippy
unneeded `return` statement
Check warning on line 3 in crates/ark-core/src/managers/block_manager.rs
GitHub Actions / clippy
unused import: `BlockInfo`
Check warning on line 1 in crates/ark-core/src/managers/collection_manager.rs
GitHub Actions / clippy
unused import: `anyhow`
Check warning on line 15 in crates/ark-core/src/managers/event_manager.rs
GitHub Actions / clippy
field `client` is never read
Check warning on line 31 in crates/ark-core/src/managers/event_manager.rs
GitHub Actions / clippy
unneeded `return` statement
Check warning on line 35 in crates/ark-core/src/managers/token_manager.rs
GitHub Actions / clippy
using `clone` on type `u64` which implements the `Copy` trait
Check warning on line 53 in crates/ark-core/src/managers/token_manager.rs
GitHub Actions / clippy
useless conversion to the same type: `starknet::core::types::FieldElement`
Check warning on line 54 in crates/ark-core/src/managers/token_manager.rs
GitHub Actions / clippy
useless conversion to the same type: `starknet::core::types::FieldElement`
Check warning on line 40 in crates/ark-storage/src/storage_manager.rs
GitHub Actions / clippy
you should consider adding a `Default` implementation for `DefaultStorage`