Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for erc1155 #473

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

manlikeHB
Copy link

@manlikeHB manlikeHB commented Oct 1, 2024

Description

This PR extends the existing NFT orderbook smart contract to add support for the ERC-1155 token standard

  • ERC-1155 token contract successfully deployed on devnet
  • Orderbook smart contract updated to support ERC-1155 tokens
  • All existing ERC-721 functionality remains intact
  • New ERC-1155 specific functions are implemented and tested
  • Quantity handling is correctly implemented for ERC-1155 tokens
  • All tests pass, including new tests for ERC-1155 functionality
  • PR must be made with the branch https://github.com/ArkProjectNFTs/ark-project/tree/feat/contract-v2 as a base

What type of PR is this? (check all applicable)

  • 🍕 Feature (feat:)
  • 🧑‍💻 Code Refactor (refactor:)
  • ✅ Test (test:)
  • 🚀 Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

  • 👍 yes

Added to documentation?

  • 📜 README.md

Closing Issues

Closes #190

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: e103e03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manlikeHB manlikeHB marked this pull request as ready for review October 3, 2024 18:50
@manlikeHB
Copy link
Author

@ptisserand @kwiss, PR ready for review.

@kwiss
Copy link
Contributor

kwiss commented Oct 10, 2024

Hey i'm gonna merge that @manlikeHB thanks for your work, there's some changes needed but we'll do that on our side, but globally it's good

@kwiss kwiss merged commit 79affd9 into ArkProjectNFTs:feat/contract-v2 Oct 10, 2024
2 of 3 checks passed
@manlikeHB
Copy link
Author

Alright, it's my pleasure.

@manlikeHB manlikeHB deleted the support-for-erc1155 branch October 10, 2024 16:00
@ptisserand ptisserand mentioned this pull request Oct 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants