feat(core): build constant file for contract addresses #235

remiroyc · 2024-01-02T17:59:44Z

No description provided.

kwiss · 2024-01-08T11:38:14Z

Check this PR for the modified Deployer cli
#237
Also since with that one we deploy based on the file we need to keep the content for the goerli network & mainnet
so the clean contract function should remove only the targeted network ?
https://github.com/ArkProjectNFTs/ark-project/pull/235/files#diff-c15c473cfbf4be252f0f80fca0ac854307b232ee5c300a2a8b8af2936290e8d7

remiroyc changed the title ~~feat(core): build contract addresses contant file~~ feat(core): build contant file for contract addresses Jan 2, 2024

remiroyc requested a review from kwiss January 2, 2024 18:00

remiroyc added 6 commits January 3, 2024 11:24

feat(core): build contract addresses contant file

d0b6e5f

feat: add build:constants cmd

3ccd62c

refactor: constants

53528e0

refactor: build script

58a1cd8

fix: unit tests

e406a27

fix: starknet example nft address

a11f419

remiroyc force-pushed the feat/build-constants branch 2 times, most recently from d73b29f to a11f419 Compare January 3, 2024 10:26

remiroyc marked this pull request as ready for review January 3, 2024 10:26

remiroyc added 6 commits January 3, 2024 11:28

refactor: clean useless type

d2d5be6

fix: network

f9cde0e

fix: networks type

c728eb2

fix: network type

0d3c24e

refactor: deployer network

0143775

fix commands

846ddd6

kwiss changed the title ~~feat(core): build contant file for contract addresses~~ feat(core): build constant file for contract addresses Jan 4, 2024

feat(core): approve (#236)

9f7d257

kwiss closed this Jan 18, 2024

Provide feedback