Skip to content

fix: remove old github workflows (#93) #258

fix: remove old github workflows (#93)

fix: remove old github workflows (#93) #258

Triggered via push September 15, 2023 00:28
Status Failure
Total duration 3m 36s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

clippy-check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 18 warnings
clippy_check
Process completed with exit code 101.
function `init_aws` is never used: src/storage.rs#L12
warning: function `init_aws` is never used --> src/storage.rs:12:8 | 12 | pub fn init_aws() { | ^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this import is redundant: src/main.rs#L4
warning: this import is redundant --> src/main.rs:4:1 | 4 | use ark_core; | ^^^^^^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports = note: `#[warn(clippy::single_component_path_imports)]` on by default
unneeded `return` statement: crates/ark-core/src/lib.rs#L122
warning: unneeded `return` statement --> crates/ark-core/src/lib.rs:122:9 | 122 | return to; | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 122 - return to; 122 + to |
unneeded `return` statement: crates/ark-core/src/lib.rs#L117
warning: unneeded `return` statement --> crates/ark-core/src/lib.rs:117:9 | 117 | / return client 118 | | .block_number() 119 | | .await 120 | | .expect("Can't fetch last block number"); | |____________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 117 ~ client 118 + .block_number() 119 + .await 120 ~ .expect("Can't fetch last block number") |
useless conversion to the same type: `starknet::core::types::FieldElement`: crates/ark-core/src/managers/token_manager.rs#L54
warning: useless conversion to the same type: `starknet::core::types::FieldElement` --> crates/ark-core/src/managers/token_manager.rs:54:17 | 54 | FieldElement::from(event.token_id.high), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `FieldElement::from()`: `event.token_id.high` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `starknet::core::types::FieldElement`: crates/ark-core/src/managers/token_manager.rs#L53
warning: useless conversion to the same type: `starknet::core::types::FieldElement` --> crates/ark-core/src/managers/token_manager.rs:53:17 | 53 | FieldElement::from(event.token_id.low), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `FieldElement::from()`: `event.token_id.low` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
using `clone` on type `u64` which implements the `Copy` trait: crates/ark-core/src/managers/token_manager.rs#L35
warning: using `clone` on type `u64` which implements the `Copy` trait --> crates/ark-core/src/managers/token_manager.rs:35:32 | 35 | self.token.timestamp = event.timestamp.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `event.timestamp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
unneeded `return` statement: crates/ark-core/src/managers/event_manager.rs#L31
warning: unneeded `return` statement --> crates/ark-core/src/managers/event_manager.rs:31:9 | 31 | return Some(vec![vec![TRANSFER_SELECTOR]]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 31 - return Some(vec![vec![TRANSFER_SELECTOR]]); 31 + Some(vec![vec![TRANSFER_SELECTOR]]) |
field `client` is never read: crates/ark-core/src/managers/event_manager.rs#L15
warning: field `client` is never read --> crates/ark-core/src/managers/event_manager.rs:15:5 | 13 | pub struct EventManager<'a, T: StorageManager, C: StarknetClient> { | ------------ field in this struct 14 | storage: &'a T, 15 | client: &'a C, | ^^^^^^ | = note: `EventManager` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
unused import: `BlockInfo`: crates/ark-core/src/managers/block_manager.rs#L3
warning: unused import: `BlockInfo` --> crates/ark-core/src/managers/block_manager.rs:3:47 | 3 | use ark_storage::types::{BlockIndexingStatus, BlockInfo}; | ^^^^^^^^^
unused import: `anyhow`: crates/ark-core/src/managers/collection_manager.rs#L1
warning: unused import: `anyhow` --> crates/ark-core/src/managers/collection_manager.rs:1:14 | 1 | use anyhow::{anyhow, Result}; | ^^^^^^ | = note: `#[warn(unused_imports)]` on by default
methods called `new` usually return `Self`: crates/ark-starknet/src/client.rs#L14
warning: methods called `new` usually return `Self` --> crates/ark-starknet/src/client.rs:14:5 | 14 | fn new(rpc_url: &str) -> Result<StarknetClientHttp>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self = note: `#[warn(clippy::new_ret_no_self)]` on by default
you should consider adding a `Default` implementation for `DefaultStorage`: crates/ark-storage/src/storage_manager.rs#L38
warning: you should consider adding a `Default` implementation for `DefaultStorage` --> crates/ark-storage/src/storage_manager.rs:38:5 | 38 | / pub fn new() -> Self { 39 | | Self 40 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 37 + impl Default for DefaultStorage { 38 + fn default() -> Self { 39 + Self::new() 40 + } 41 + } |
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/