Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add time range arguments to span query helper functions #2645

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: add time range arguments to span query helper functions #2645

merged 1 commit into from
Mar 20, 2024

Conversation

axiomofjoy
Copy link
Contributor

Adds start_time and end_time arguments to get_qa_with_reference and get_retrieved_documents.

resolves #2644

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 20, 2024
@axiomofjoy
Copy link
Contributor Author

Fast-follow: Update API reference documentation for get_qa_with_reference and get_retrieved_documents.

@axiomofjoy axiomofjoy mentioned this pull request Mar 20, 2024
Closed
@axiomofjoy axiomofjoy merged commit 8bb2e85 into main Mar 20, 2024
13 checks passed
@axiomofjoy axiomofjoy deleted the add-time-range-to-span-query-helper-functions-2644 branch March 20, 2024 02:23
mikeldking pushed a commit that referenced this pull request Mar 20, 2024
@axiomofjoy @mikeldking
add time range arguments to span query helper functions (#2645)
e9047fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add time range arguments to span query helper functions
2 participants
@axiomofjoy @RogerHYang