-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds prometheus metrics #37
base: master
Are you sure you want to change the base?
Conversation
Adds endpoint for prometheus metrics and instrument the snapshot function. This allows for alerts to be created when snapshots fail or have not been taken for some time.
Hey @Argelbargel, I've added some prometheus metrics, as I like to alert if backups fail. This allows me to generate alerts via alert manager, e.g.
Will also add additional serviceMonitor and ports to your helm chart if you're happy with this. |
Hi @anguswilliams, sorry, did not have the time yet to review your pull-request. I'll try to find some time for it this week... |
Hi @anguswilliams, thanks a lot this PR. I tried to test it locally:
Using the following config.yaml file:
Provided feature seems to work as expected:
Could you also provide some documentation on how you can access the metrics and what's the idea behind each metric? @Argelbargel can you also have a look at it and maybe we can merge it ? Thank you very much. |
Hi @Argelbargel, another kind reminder as we are depending a bit on this feature. |
Adds endpoint for prometheus metrics and instrument the snapshot function.
This allows for alerts to be created when snapshots fail or have not been taken for some time.