Skip to content

Commit

Permalink
Improve E2E Stability for Android (facebook#48286)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#48286

This change bumps the specs for the Android E2E tests. This has been reported to improve the stability of the tests.

We need to keep part of the `flatlist.yml` commented as it creates an issue with Maestro as it takes too much memory.

I'll reach out to the people working on Maestro to try and understand what's going on there.

## Changelog:
[Internal] - Improve android Stability and reenable E2E tests on main

Reviewed By: fabriziocucci

Differential Revision: D67276601

fbshipit-source-id: 7cca253547063a0ec39da7de58806286c6632b07
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Dec 17, 2024
1 parent b511a95 commit 03b9f04
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .github/actions/maestro-android/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ runs:
with:
api-level: 24
arch: x86
ram-size: '4096M'
ram-size: '8192M'
heap-sizze: '4096M'
disk-size: '10G'
cores: '4'
disable-animations: false
avd-name: e2e_emulator
script: node .github/workflow-scripts/maestro-android.js ${{ inputs.app-path }} ${{ inputs.app-id }} ${{ inputs.maestro-flow }} ${{ inputs.flavor }} ${{ inputs.working-directory }}
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -436,9 +436,7 @@ jobs:
run-e2e-tests: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }}

test_e2e_android_rntester:
# Temporarily disable RNTester tests on Android as they are quite flaky and they make CI always red
# if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }}
if: ${{ contains(github.ref, 'stable') || inputs.run-e2e-tests }}
if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }}
runs-on: 4-core-ubuntu
needs: [build_android]
strategy:
Expand Down
4 changes: 2 additions & 2 deletions packages/rn-tester/.maestro/flatlist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebo
id: "Flatlist"
- tapOn:
id: "Basic"
# - assertVisible:
# id: "item_550"
- assertVisible:
id: "item_550"
# - repeat:
# while:
# notVisible:
Expand Down

0 comments on commit 03b9f04

Please sign in to comment.