Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: update pose and lift plugin #43

Merged
merged 4 commits into from
Jan 21, 2024

Conversation

srmainwaring
Copy link
Collaborator

Update pose following:

Ensure <cma> element is set to zero in LiftDrag plugin following:

Other changes

- Changed behaviour in Gazebo Harmonic.

Signed-off-by: Rhys Mainwaring <[email protected]>
- iris_with_standoffs pose changed in ArduPilot/ardupilot_gazebo#68

Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring added the bug Something isn't working label Dec 23, 2023
@srmainwaring srmainwaring self-assigned this Dec 23, 2023
@srmainwaring
Copy link
Collaborator Author

@Ryanf55 - now that

have been merged, this needs to be merged to fix the gimbal offset. Most of the changes are formatting, the key one is

<link name="base_scan">
<pose>0 0 0.075077 0 0 0</pose>

If you can approve please, I'll merge.

Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm other than one value. If it's right, just merge it.

@@ -69,13 +69,13 @@

<include>
<uri>model://runway</uri>
<pose>0 0 0 0 0 1.57079632</pose>
<pose degrees="true">-29 545 0 0 0 363</pose>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 360 degrees?

Copy link
Collaborator Author

@srmainwaring srmainwaring Jan 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 360 degrees?

CUAV airport does not quite lie N-S and I've attempted to align with that as it's the default location for AP SITL. But 003 deg would have been better! I'll get those next time...

@srmainwaring srmainwaring merged commit 000c1e0 into ArduPilot:main Jan 21, 2024
@srmainwaring srmainwaring deleted the prs/pr-copter-pose branch January 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants