-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gimbal: Added rc channel control readme #104
Conversation
Thanks for the PR @snktshrma. Looks good. Have suggested a few changes. A screenshots of the QGC settings page might help clarify the setup, but not essential. |
82e3dd2
to
c68db82
Compare
Hi @srmainwaring! I have resolved the requested changes and added a screenshot of QGC settings page! |
@snktshrma, Thanks for this. The QGC image isn't appear for me and the url looks a bit suspicious (https://private-user-images.githubusercontent.com/74557164/344478908-f55242f3-cff8-4f81-befd-da68e4df73c6.png). |
Hi @rmackay9 sir! I have updated the image! Hopefully it's visible now |
- Update QGC settings image. - Match gimbal limits in README with params. - Remove params not modified from defaults Signed-off-by: Rhys Mainwaring <[email protected]>
b7da187
to
d6adbac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @snktshrma. I've rebased to bring the parameters up to date with main
and referenced the QGC image from this repo rather than your fork.
- Sync physics settings for ros2 - Remove IR lock params - Add MOT_PWM params - Default to iris with gimbal - Update zephyr parachute example - Update 3DoF gimbal URIs to use ament packages - Switch iris to use the 3DoF gimbal Signed-off-by: Rhys Mainwaring <[email protected]>
- Sync physics settings for ros2 - Remove IR lock params - Add MOT_PWM params - Default to iris with gimbal - Update zephyr parachute example - Update 3DoF gimbal URIs to use ament packages - Switch iris to use the 3DoF gimbal Signed-off-by: Rhys Mainwaring <[email protected]>
In reference to the PR by @srmainwaring. Updated readme to setup and control gimbal over ground control.