Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gimbal: Added rc channel control readme #104

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

snktshrma
Copy link
Contributor

In reference to the PR by @srmainwaring. Updated readme to setup and control gimbal over ground control.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/gazebo-iris-gimbal.parm Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@srmainwaring
Copy link
Collaborator

Thanks for the PR @snktshrma. Looks good. Have suggested a few changes. A screenshots of the QGC settings page might help clarify the setup, but not essential.

@snktshrma snktshrma force-pushed the pr-wiki-3d-gimbal branch from 82e3dd2 to c68db82 Compare June 30, 2024 16:14
@snktshrma
Copy link
Contributor Author

Hi @srmainwaring! I have resolved the requested changes and added a screenshot of QGC settings page!

@snktshrma snktshrma requested a review from srmainwaring June 30, 2024 21:40
@rmackay9
Copy link

@snktshrma, Thanks for this. The QGC image isn't appear for me and the url looks a bit suspicious (https://private-user-images.githubusercontent.com/74557164/344478908-f55242f3-cff8-4f81-befd-da68e4df73c6.png).

@snktshrma
Copy link
Contributor Author

Hi @rmackay9 sir! I have updated the image! Hopefully it's visible now

@srmainwaring
Copy link
Collaborator

Adding resized image here so it can be referenced from as an asset in the main repo.

qgc_video_settings

- Update QGC settings image.
- Match gimbal limits in README with params.
- Remove params not modified from defaults

Signed-off-by: Rhys Mainwaring <[email protected]>
Copy link
Collaborator

@srmainwaring srmainwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @snktshrma. I've rebased to bring the parameters up to date with main and referenced the QGC image from this repo rather than your fork.

@srmainwaring srmainwaring merged commit 2baeeec into ArduPilot:main Sep 11, 2024
3 checks passed
@srmainwaring srmainwaring mentioned this pull request Oct 30, 2024
srmainwaring added a commit to srmainwaring/ardupilot_gazebo-1 that referenced this pull request Oct 30, 2024
- Sync physics settings for ros2
- Remove IR lock params
- Add MOT_PWM params
- Default to iris with gimbal
- Update zephyr parachute example
- Update 3DoF gimbal URIs to use ament packages
- Switch iris to use the 3DoF gimbal

Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit that referenced this pull request Nov 4, 2024
- Sync physics settings for ros2
- Remove IR lock params
- Add MOT_PWM params
- Default to iris with gimbal
- Update zephyr parachute example
- Update 3DoF gimbal URIs to use ament packages
- Switch iris to use the 3DoF gimbal

Signed-off-by: Rhys Mainwaring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants