Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed note creation outside of gameplay viewport #56

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 9 additions & 63 deletions Assets/Fonts/NotoSans-Regular SDF.asset

Large diffs are not rendered by default.

236 changes: 10 additions & 226 deletions Assets/Fonts/SourceCodePro-Regular SDF.asset

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Assets/Materials/Compose/Waveform.mat
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Material:
- _SmoothnessTextureChannel: 0
- _SpecularHighlights: 1
- _SrcBlend: 1
- _ToSample: 18531754
- _ToSample: 0
- _UVSec: 0
- _ZWrite: 1
m_Colors:
Expand Down
1 change: 1 addition & 0 deletions Assets/Scripts/Compose/Editing/NoteCreation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public async UniTask StartCreatingNote(EditorAction action)

if (!Services.Cursor.IsHittingLane
|| selectionChanged
|| !Services.Cursor.IsCursorAboveViewport
|| (Values.CreateNoteMode.Value != CreateNoteMode.ArcTap && selectionSize != 0))
{
return;
Expand Down