Refactor disassemble #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate function and add error return handling in the 'go style'.
…stead of main package.
|
Seems like a fine idea to me. Only thing I'd suggest is that |
|
Good call, let me work on this.
On Sat, Jun 17, 2017 at 1:45 Nick Johnson ***@***.***> wrote:
Seems like a fine idea to me. Only thing I'd suggest is that Disassemble
should either return a slice of strings, one per line (which is more
efficient), or even better some kind of AST that can be recursively
stringified.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFlwAwH07xEsTrY9cyyJWr43h18h512uks5sErEogaJpZM4N08Fi>
.
--
Jeff Wentworth
Co-founder, Curvegrid
www.curvegrid.com
|
|
curvegrid:refactor-disassemble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Arachnid let me know what you think about this: speculative refactoring of disassemble functions into its own package, to allow for (near) future work on 'evmdiff' within this project. Also, let me know if you'd prefer I open Issues and working off of that before sending Pull requests - should have asked first!