Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added necessary build.gradle file changes for Gradle 7+ #30

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

sermaz
Copy link

@sermaz sermaz commented Aug 8, 2021

No description provided.

@iuliana
Copy link
Collaborator

iuliana commented Aug 31, 2021

Hi @sermaz ,

This is a lot of work and I appreciate it, but it feels weird to me to change the project to support a build tool, when in most cases it is the other way around. :)

I'll take a look at your changes as soon as I can and merge them if they are still in line with the code in the book.
Thank you for your contribution!

Cheers,
Iuliana Cosmina

@iuliana
Copy link
Collaborator

iuliana commented Sep 7, 2021

Hello sermaz,

Thank you for the initiative, but the project doesn't seem to build with Gradle 7. Have you even tried a full build?
I will try to make it work, because you've made me curious, but I won't merge your commits until the full build passes.

Cheers,
Iuliana Cosmina

@valentyn-red-bird
Copy link

@iuliana everything works! I am so happy to find this pull request! I had many problems making it run with Gradle 7.*. Maybe, it will be great to provide instructions on how to configure Gradle's older version in Intellij IDEA at least, if you are not planning to merge this pull.

@iuliana
Copy link
Collaborator

iuliana commented Dec 16, 2021

@iuliana everything works! I am so happy to find this pull request! I had many problems making it run with Gradle 7.*. Maybe, it will be great to provide instructions on how to configure Gradle's older version in Intellij IDEA at least, if you are not planning to merge this pull.

@valentyn-nahai the older version of Gradle, which is 5.x, the one mentioned in the README.md , works out of the box with the tests and the AspectJ module. This pull request does not. This is why I am not merging it.

@valentyn-red-bird
Copy link

Thanks for the update! I appreciate your answer.

@iuliana
Copy link
Collaborator

iuliana commented Dec 16, 2021

Thanks for the update! I appreciate your answer.

@valentyn-nahai this project is pretty old. Upgrading it to Gradle 7 might require changes that are making it incompatible with the text in the book. The book does explain a few details about the Gradle configurations and plugins used. Some of those plugins are not maintained nor upgraded to more recent Gradle versions. But there will be a book called "Pro Spring 6" in a year or two. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants