-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added redis with event source module #76
base: main
Are you sure you want to change the base?
Conversation
Unit Test Results0 files - 2 0 suites - 2 0s ⏱️ -46s Results for commit 2fb2aef. ± Comparison against base commit 099c293. This pull request removes 181 tests.
♻️ This comment has been updated with latest results. |
redis plus plus works only with 17 so we should try to see if any other module breaks
looks like it is not compatible with 1.3.1 redis++ port on vcpkg. The version I had built from source was 1.3.2 , hence the port must be added or it should be built from source. |
I made a PR for updating redis++ version to 1.3.2 on vcpkg which got approved here. Please pull it from upstream to apralabs/vcpkg submodule. This should fix the issue. |
@AkshayPS12 awesome! sorry for the late response. I will look into this! Thanks! |
I have updated the vcpkg submodule @AkshayPS12 can you just check if it works |
vcpkg old cache persisting , checksums for cache rebuild should have more context/logic |
For creating listening to events and using setProps to change props of running modules. In this case events are generated by redis keyspace notifications.
Checklist