-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added processEOS and resolved issue #335 with unit test #336
base: main
Are you sure you want to change the base?
Conversation
Test Results Linux 1 files ±0 1 suites ±0 10m 13s ⏱️ -1s Results for commit 4a29bf9. ± Comparison against base commit 53157e2. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results Win-nocuda 1 files ±0 1 suites ±0 10m 27s ⏱️ +6s Results for commit 4a29bf9. ± Comparison against base commit 53157e2. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results Linux-CudaT 1 files ±0 1 suites ±0 10m 34s ⏱️ +5s Results for commit 4ab2e39. ± Comparison against base commit 5358310. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
|
Test Results Linux_ARM64 1 files ±0 1 suites ±0 10m 57s ⏱️ +4s Results for commit 4ab2e39. ± Comparison against base commit 5358310. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
|
Test Results Windows-cuda 1 files ±0 1 suites ±0 12m 20s ⏱️ +2s Results for commit 4a29bf9. ± Comparison against base commit 53157e2. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…buffer-size-is-less-than-set-buffer_size-in-audiototextxform-module
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #335
Description
Added processEOS for AudioToTextXForm module, implemented a handleflushbuffer function to clear the buffer and send an EOS frame when the buffer size is less than set buffer_size, added a unit test to check handleflushbuffer
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: Bug fix
Screenshots (if applicable)
Checklist