Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppsFlyer library import #12

Closed
wants to merge 1 commit into from
Closed

Conversation

gogisha
Copy link

@gogisha gogisha commented Jan 30, 2017

The latest AppsFlyer SDK has changed the required import statement from:

#import <AppsFlyerTracker/AppsFlyerTracker.h>

to:

#import <AppsFlyerLib/AppsFlyerTracker.h>

So the integration will no longer compile. This should fix the issue.

The latest AppsFlyer SDK has changed the required import statement from:

#import <AppsFlyerTracker/AppsFlyerTracker.h>

to:

#import <AppsFlyerLib/AppsFlyerTracker.h>

So the integration will no longer compile. This should fix the issue.
@genericwoods
Copy link

👍 I’m awaiting this fix for our AppsFlyer integration

@af-fess
Copy link
Contributor

af-fess commented Feb 19, 2017

@gogisha @genericwoods As you know AppsFlyerLib.framework is a static framework.
We want to remove segment-appsflyer-ios from pod due to Cocoapods limitations. For Swift you are including use_frameworks! in podfile and are using a transitive dependency that should be dynamic framework.

Instead We suggest to install pod 'AppsFlyerFramework' (today its 4.6.5) and copy manually 5 files directly to your project (I would create some folder af_bridge):

  • SEGAppsFlyerIntegration.h
  • SEGAppsFlyerIntegration.m
  • SegAppsFlyerIntegrationFactory.h
  • SegAppsFlyerIntegrationFactory.m
  • SegmentAppsFlyeriOS.h

we will post 2 examples for Obj-C and Swift cases.

Anyways because of static framework we cannot release segment-appsflyer-ios to Cocoapods and we don't think that setting def installer.verify_no_static_framework_transitive_dependencies; end to podspec is a best bet, at least in short term.

related ref:

segment-integrations/analytics-ios-integration-google-analytics#3 (comment)

CocoaPods/CocoaPods#2926

@gogisha
Copy link
Author

gogisha commented Mar 1, 2017

Gotcha @af-fess . Will there be any way to know if those 5 files will ever need to be updated?

@af-fess
Copy link
Contributor

af-fess commented Mar 2, 2017

@gogisha generally there is no reason to change public API, only if we decide to add new methods/features. The AppsFlyerFramework native SDK you will get with pod update and for sure, we handle backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants