Refactor: Updated location of components. #26
Conversation
dlabaj
requested review from
EricWittmann,
christiemolloy,
jenny-s51 and
mfrances17
| function findId(array: Array<any>, id: string) { | ||
| var apiTemp = array.find(api => api.id === id); | ||
| if (apiTemp != undefined) { | ||
| function findId(array: any[], id: string) { |
There was a problem hiding this comment.
Why use an inline function like this rather than e.g. a static method? Also either way it should probably have a declared return value in the signature.
packages/studio/package.json
Outdated
| @@ -35,6 +35,7 @@ | |||
| "jest": "^24.1.0", | |||
| "keycloak-js": "9.0.0", | |||
| "mini-css-extract-plugin": "^0.4.5", | |||
| "nodemon": "2.0.2", | |||
There was a problem hiding this comment.
OK so I couldn't figure out why this was added.
There was a problem hiding this comment.
lol I love the image. It was originally added because I was working on a fix for for rebuilding the model and services and thought about using nodemon. I'll remove it lol.
packages/studio/src/app/components/api/apiDrawer/apiDrawerPanelContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
seeing the same thing as @jenny-s51 and @mfrances17 reported here
|
@christiemolloy @EricWittmann @jenny-s51 @mfrances17 Addressed review comments. Let me know if there's anything else. Thanks. |
|
Drawer is broken
|
| padding: 0 !important; | ||
| } | ||
|
|
||
| .ap--drawer-panel-body .pf-c-drawer__panel-body { |
There was a problem hiding this comment.
incorrect spelling this is why the padding is there
dlabaj
dismissed stale reviews from jenny-s51, mfrances17, and EricWittmann
via
93c20a9
Refactor code to move components into components folder. Updated some of the components name to correspond with where they are used. Added barrel files for imports.
Fixes issue #20