feat: use preferred .site_package key instead of .python for less confusion
#2411
+26
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Dec 11, 2024
| @@ -405,14 +405,12 @@ def _get_version_from_package_json( | |||
| return data.get("version") | |||
|
|
|||
|
|
|||
| # TODO: Rename to `PyPIDependency` in 0.9. | |||
There was a problem hiding this comment.
decided not going to do this one either
bitwise-constructs
previously approved these changes
Dec 11, 2024
bitwise-constructs
previously approved these changes
Dec 11, 2024
antazoey
changed the title
.python key in dependencies; use either .site_package or .pypi.site_package key instead of .python for less confusion
antazoey
force-pushed
the
refactor/rename
branch
from
f38394e to
a11b0f8
Compare
bitwise-constructs
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Prep work for 0.9, deprecates a key and adds the other one in a non-breaking way.
In 0.9 we can fully remove now.
How I did it
How to verify it
Checklist