-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support web3.py v7 (in addition to v6) #2394
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3569a92
feat: upgrade web3
antazoey 5273714
test: update tests
antazoey eda83eb
feat: make work on both
antazoey 96e3f9d
fix: pin adjust
antazoey c8038fc
feat: websocket provider
antazoey c310ddf
fix: req header
antazoey a1a1647
fix: conditions
antazoey 4ec244c
chore: add no type on ValueError
evan-quest 968b0bb
chore: loosen rest of pins
antazoey b3f4293
Merge branch 'main' into feat/upgrade-web3
antazoey ff049b9
fix: w3pin
antazoey d75122c
Merge branch 'main' into feat/upgrade-web3
antazoey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
from eth_account import Account as EthAccount | ||
|
||
try: | ||
# Web3 v7 | ||
from web3.middleware import ExtraDataToPOAMiddleware # type: ignore | ||
except ImportError: | ||
from web3.middleware import geth_poa_middleware as ExtraDataToPOAMiddleware # type: ignore | ||
|
||
try: | ||
from web3.providers import WebsocketProviderV2 as WebsocketProvider # type: ignore | ||
except ImportError: | ||
from web3.providers import WebSocketProvider as WebsocketProvider # type: ignore | ||
|
||
|
||
def sign_hash(msghash, private_key): | ||
try: | ||
# Web3 v7 | ||
return EthAccount.unsafe_sign_hash(msghash, private_key) # type: ignore | ||
except AttributeError: | ||
# Web3 v6 | ||
return EthAccount.signHash(msghash, private_key) # type: ignore | ||
|
||
|
||
__all__ = [ | ||
"ExtraDataToPOAMiddleware", | ||
"sign_hash", | ||
"WebsocketProvider", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to reviewer: this basically makes it the same as it was before, v7 changes this method to make it more web3-specific by including a required module arg