Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: most performant .return_value calculation #2225

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

antazoey
Copy link
Member

What I did

Finally - .return_value is speedy as it ever was.

stats:

 Before:
 10 passed in 197.45s (0:03:17)
 After:
 10 passed in 69.65s (0:01:09) 

How I did it

if possible, use a barely enriched raw call tree, as opposed to a fully enriched (least performant) and a trace-calculated return (middle performance).
this is by far the best.

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey marked this pull request as ready for review August 20, 2024 20:33
@antazoey antazoey requested a review from fubuloubu August 21, 2024 14:42
@antazoey antazoey merged commit 04934de into ApeWorX:main Aug 21, 2024
16 checks passed
@antazoey antazoey deleted the perf/returnval branch August 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants