-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle when local dependency is already a manifest [APE-1397] #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a side note about ape-safe
, we added NPM dependencies to pivot that repo away from using the local uploaded copy eventually (so we can support more than just v1.3.0)
Yes, I noticed the NPM thing - we can still definitely go that route. But I wish this could have been the temporary fix. |
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this change if you want to rebase it
What I did
I was annoyed when I saw ape-safe had to manually copy the manifest into the packages folder, that seemed so unnecessary.
I made it so if you use a local dependency and it is already a manifest, it just copies it in that way.
How I did it
Check if is a JSON manifest file and if it, copy it on.
How to verify it
In ape-safe, you can delete that
mkdir
line if you use this PR and this config:I can open a draft PR after this
Checklist