fix: Updated cervical rhythm implmentation #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oracic model. The cervical link driver now connects the cervical rhythm to the entire spine motion. This way it will also work even though the rigid thorax is used. This commit also modfies the links rhythm coefficients so they are no longer recalculated as as ratios, but instead uses the values of the coefficient from excel sheet directly. This makes it easier for us to see where the values come from
…ll rhythm is enabled.
melund
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the thoracic model configuration, rhythm drivers. The most important changes include the addition of a flexible thorax model, adjustments to rhythm driver coefficients, and updates to documentation and default settings.
@Hamedshayestehpour I have fixed the problem you found with the Thoracic example not working with the rigid thorax.
This PR refactors the cervical rhythm link. When the link is enabled it now links the cervical rhythm to the entire spine (pelvis-T1 measure). This means that the link works both for the detailed and the rigid thorax. To accomplish this I needed to move the implementation to the "JointsCervical.any" file.
The coefficients for the rhythm links have also been changed to they are now given directly by the values from the 'excel' sheet where the rhythm was created. I still need to add more documentation on the rhythm to the AMMR. But that may come in future PR.
Thoracic Model Configuration:
Thoracic.main.any.Rhythm Driver Adjustments:
JointsThorax.any. [1] [2] [3]JointsCervical.any.