Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Mine Speed Game Rule Implementation and World Processor Set Rule for Unit Mine Speed, and Unit Crash Damage. #10318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SomeonesShade
Copy link
Contributor

@SomeonesShade SomeonesShade commented Nov 10, 2024

Implmentation

Implements Anuken/Mindustry-Suggestions#5305
Also: Includes Unit Crash Damage in the world proc, mostly for symmetry and completing the unit variable list...
Can be reverted easily probably?

Details

  • Implemented the main game rule itself
unitminespeed.1.MOV
unitminespeed.2.MOV
  • World Processor being able to adjust it
unitminespeed.3.MOV
  • Bonus: World Processor being able to adjust crash damage...
unitcrashdamage.mp4

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@SomeonesShade
Copy link
Contributor Author

SomeonesShade commented Nov 10, 2024

Okay seems ready now, I'm probably on the fence on adding crash damage along as well? I have it ready to be easily done...

I'll decide in 8 hrs from now prob

Wait no, ill just commit it in, it can be reverted

@SomeonesShade SomeonesShade changed the title Unit Mine Speed Game Rule Implementation Unit Mine Speed Game Rule Implementation and World Processor Set Rule for Unit Mine Speed, and Unit Crash Damage. Nov 10, 2024
@JasonP01
Copy link
Contributor

Why 2 instances of unitMineSpeedMultiplier in Rules.java

@SomeonesShade
Copy link
Contributor Author

SomeonesShade commented Nov 10, 2024

Why 2 instances of unitMineSpeedMultiplier in Rules.java

There are 2 instances of everything else, so I just followed

Makes sence ish since the value in the rules vs value from the world proc combines (in this case multiplication)

@JasonP01
Copy link
Contributor

There are 2 instances of everything else, so I just followed

Ye, nevermind.. didnt notice that one is the global variable and the other is specific to team specific rules

@SomeonesShade
Copy link
Contributor Author

Wait... right unit crash damage already exists on the per team thing...

welp now I need to think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants