Added scaleLifetimeOffset and Centered Ripple Projectiles #10292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed ripple to have its shot centered, calculated by: (1 - velocityRnd/2)^-1
|
(uncertain if this is a good name, a simple rename/refactor probably works) |
SomeonesShade
changed the title
one last adjustement, hopefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added scaleLifetimeOffset for one main purpose: to offset scale lifetime bullets
For example, ripple now has its projectile centered, no need to adjust the velocityRnd to do so.
For testing that the centering works
Set the
inaccuracy = 0,shoot.shots = 100, andrange = 1000out.mov
Before
bout.mov
After
aout.mov
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: