Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add_ci_windows_build #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wakiyamap
Copy link

ref. #11

result https://github.com/wakiyamap/fastecdsa/actions/runs/5248489262

I'm using google translate, so sorry if it's weird English.
I didn't know how to make it compatible with x86.
https://github.com/wakiyamap/fastecdsa/actions/runs/5234386828
But I don't think there are any users who use x86 right now, so I made a pull request for x64 only.

@wakiyamap
Copy link
Author

In actual operation, I think it is better to enable the cache as @ShadowJonathan wrote. However, I didn't write it there because I don't know if I can pull-request it due to copyright issues.

@AntonKueltz
Copy link
Owner

AntonKueltz commented Jun 20, 2023

Hi, thanks for the PR! Were you able to verify that the wheel generated by the CI job result in a functional installation of the package? E.g. with a fresh python virtual env the following runs without issue?

pip install <fastecdsa windows wheel>
python -m fastecdsa.benchmark

@wakiyamap
Copy link
Author

wakiyamap commented Jul 23, 2023

Sorry for the late response.

As far as I tested it, it seems to be fine.
https://github.com/wakiyamap/fastecdsa/actions/runs/5633774713/job/15263033995

@AntonKueltz
Copy link
Owner

No worries, the CI/CD jobs passing is a good start, but it would be good to verify the wheels produced actually work when installed on a fresh environment on Windows.

@wakiyamap
Copy link
Author

Thanks!
I have verified that it works locally.
Also, commands executed by CIBW_TEST_COMMAND_WINDOWS are executed in a fresh environment created by virtualenv.
https://github.com/wakiyamap/fastecdsa/actions/runs/5633774713/job/15263033995#step:3:381
image

@wakiyamap
Copy link
Author

Did you decide not to use wheel?

@AntonKueltz
Copy link
Owner

AntonKueltz commented Oct 17, 2023

I've removed the current actions as they were still breaking intermittently and were causing pretty long running jobs (that sometimes ultimately failed) to get kicked off when adding new (non-release related) commits. I'm looking at adding them back, but only running conditionally on tagged (i.e. new release version) commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants