[1.0-beta2] P2P: Prevent syncing from running ahead of chain head #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t get too far ahead of chain_head
heifner
commented
Jun 13, 2024
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -3153,10 +3156,10 @@ namespace eosio { | |||
| pending_message_buffer.advance_read_ptr( message_length ); | |||
| return true; | |||
| } | |||
| peer_dlog( this, "received block ${num}, id ${id}..., latency: ${latency}ms, head ${h}", | |||
| peer_dlog( this, "received block ${num}, id ${id}..., latency: ${latency}ms, head ${h}, fdb_head ${f}", | |||
There was a problem hiding this comment.
Used fdb_head as having fork in the logs can causes confusion.
linh2931
reviewed
Jun 13, 2024
linh2931
reviewed
Jun 13, 2024
greg7mdp
approved these changes
Jun 13, 2024
linh2931
reviewed
Jun 13, 2024
linh2931
approved these changes
Jun 13, 2024
… of chain head instead of fork head
linh2931
approved these changes
Jun 13, 2024
greg7mdp
reviewed
Jun 13, 2024
greg7mdp
approved these changes
Jun 13, 2024
This was referenced Jun 13, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2P syncing was using fork database head for a limited factor on how far ahead to request blocks. With the recent change to ingest blocks quickly into the fork database (AntelopeIO/leap#2385), this allowed the fork database to load hundred of thousands of blocks ahead of chain head.
Use chain head instead of fork database head for sync ahead calculation.
Resolves #278