Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change symbols dict logic to prioritize builtins #1482

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Change symbols dict logic to prioritize builtins #1482

merged 2 commits into from
Dec 28, 2024

Conversation

ncoop57
Copy link

@ncoop57 ncoop57 commented Dec 28, 2024

This PR updates the logic for the creation of the lookup table for the python symbols in the nbdev docs api for linkifying markdown to prioritize builtins over other standard library modules.

@ncoop57 ncoop57 self-assigned this Dec 28, 2024
@ncoop57 ncoop57 marked this pull request as ready for review December 28, 2024 00:29
@ncoop57 ncoop57 requested a review from jph00 December 28, 2024 00:29
@jph00
Copy link
Contributor

jph00 commented Dec 28, 2024

Thank you! :)

@jph00 jph00 merged commit 0f66519 into main Dec 28, 2024
10 checks passed
@jph00 jph00 deleted the syms branch December 28, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants